Avoid not needed search creation on default and stream search page #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
avoid-not-needed-search-creation
branch
2 times, most recently
from
fcba5c7
to
51cded7
Compare
linuspahl
force-pushed
the
avoid-not-needed-search-creation
branch
from
51cded7
to
9fa9514
Compare
dennisoelkers
requested changes
Nov 1, 2021
| timezone: range.timezone, | ||
| } as KeywordTimeRange : undefined; | ||
| default: | ||
| // @ts-ignore |
There was a problem hiding this comment.
To avoid using @ts-ignore here, we can do two things:
- Using the complete
rangeto generate theErrorin the next line (TS is complaining becauserange.rangetypeis supposed to beneverat this point), which could also help for debugging. - Using
@ts-expect-errorinstead. This is doing the same as@ts-ignore(suppressing an error), but in addition it is raising an error if no error is suppressed. This way, we are also being notified when a new possible value forrangetypeis introduced but it is not handled in acase-clause.
There was a problem hiding this comment.
Thanks for the tip, I really like the typing related advantages of @ts-expect-error.
linuspahl
force-pushed
the
avoid-not-needed-search-creation
branch
from
9fa9514
to
fa759d1
Compare
dennisoelkers
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Before this change we we created two searches, when opening the default or stream search page via a URL with search query params like:
?q=http_method:GET&rangetype=relative&relative=300. This was not the case when opening a saved search. This problem occurred because we were creating a search with the default search query first and another one with the search settings provided by the URL query params.Please note, this bug still exists when the URL query params contain a stream filter. Fixing this bug will require more complex changes, which we should implement in a follow-up PR.