Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sliding window date time boundaries #11546

Merged
merged 6 commits into from Nov 3, 2021
Merged

Fix sliding window date time boundaries #11546

merged 6 commits into from Nov 3, 2021

Conversation

bernd
Copy link
Member

@bernd bernd commented Oct 28, 2021

This fixes an issue where the last day on the traffic graph doesn't show the full day traffic value.

image

@bernd bernd changed the title Fix sliding window date time borders Fix sliding window date time boundaries Oct 29, 2021
@bernd bernd marked this pull request as ready for review November 2, 2021 10:29
@bernd
Copy link
Member Author

bernd commented Nov 2, 2021

@mariussturm Can you please check if my changes still work with your test setup?

@bernd
Copy link
Member Author

bernd commented Nov 3, 2021

@mariussturm Any updates on this? 🙂 This is supposed to go into the bug fix release today.

@mariussturm
Copy link
Contributor

Looks good in my lab setup!

@bernd bernd merged commit 83ca06b into master Nov 3, 2021
@bernd bernd deleted the fix-traffic-count branch November 3, 2021 15:35
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window date time boundaries (#11546)

* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)

* Fix TrafficCounterServiceTest
bernd added a commit that referenced this pull request Nov 3, 2021
* Fix sliding window date time boundaries (#11546)

* Fix sliding window datetime borders
* Fix "to" in "#clusterTrafficOfLastDays" to include data up until now
* Add test for TrafficCounterService
* Add assertions for the "from" and "to" values

Co-authored-by: Marius Sturm <marius@graylog.com>
(cherry picked from commit 83ca06b)

* Fix TrafficCounterServiceTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants