New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sliding window date time boundaries #11546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd
changed the title
Fix sliding window date time borders
Fix sliding window date time boundaries
Oct 29, 2021
@mariussturm Can you please check if my changes still work with your test setup? |
@mariussturm Any updates on this? 🙂 This is supposed to go into the bug fix release today. |
Looks good in my lab setup! |
mariussturm
approved these changes
Nov 3, 2021
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b)
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b)
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b)
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b)
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window date time boundaries (#11546) * Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b) * Fix TrafficCounterServiceTest
bernd
added a commit
that referenced
this pull request
Nov 3, 2021
* Fix sliding window date time boundaries (#11546) * Fix sliding window datetime borders * Fix "to" in "#clusterTrafficOfLastDays" to include data up until now * Add test for TrafficCounterService * Add assertions for the "from" and "to" values Co-authored-by: Marius Sturm <marius@graylog.com> (cherry picked from commit 83ca06b) * Fix TrafficCounterServiceTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the last day on the traffic graph doesn't show the full day traffic value.