Center value in number visualization properly. #12424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
reviewed
Apr 8, 2022
| height: 100%; | ||
| width: 100%; | ||
| font-size: ${(props) => `${props.fontSize}px`}; | ||
| ${(props) => (props.$center ? ` |
There was a problem hiding this comment.
Let's use css from styled-components for the template string, this way stylelint and e.g. the css autocompletion will work properly.
dennisoelkers
force-pushed
the
fix/properly-center-value-in-number-vis
branch
from
e060dd0
to
4393c71
Compare
linuspahl
approved these changes
Apr 8, 2022
linuspahl
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Center value in number visualization properly. * Using `css` to generate CSS from template string.
linuspahl
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Center value in number visualization properly. * Using `css` to generate CSS from template string.
linuspahl
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Center value in number visualization properly. * Using `css` to generate CSS from template string.
This was referenced Apr 11, 2022
dennisoelkers
added a commit
that referenced
this pull request
Apr 12, 2022
dennisoelkers
added a commit
that referenced
this pull request
Apr 12, 2022
dennisoelkers
added a commit
that referenced
this pull request
Apr 12, 2022
linuspahl
pushed a commit
that referenced
this pull request
Apr 21, 2022
* Center value in number visualization properly. * Using `css` to generate CSS from template string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Prior to this PR, the number visualization of the search did not properly center the values it displays. Values were slightly misaligned towards the top of the widget.
This change is now making sure that values in a number visualization are always centered vertically and horizontally.
How Has This Been Tested?
Screenshots (if appropriate):
Before:
After:
Types of changes
Checklist: