Fix field value suggestions when quoting is used. #13087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dennisoelkers
force-pushed
the
fix/support-quoted-strings-for-field-value-suggestions
branch
from
07ece43
to
7987225
Compare
linuspahl
deleted the
fix/support-quoted-strings-for-field-value-suggestions
branch
dennisoelkers
added a commit
that referenced
this pull request
Jul 25, 2022
* Adding test. * Extracting input from quoted value properly, keeping quotation consistent for completions. * Fixing handling of empty quoted string.
9 tasks
linuspahl
pushed a commit
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing an issue with the field value completions not working when the user is starting a field value with quoting, e.g. when the user types
field:"", no completions appear.This PR is fixing this and also retains quoting information, so when the user uses quoting, the value returned is not escaped, if the user is not using quoting, escaping is used.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: