Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom default Reader role #13383

Closed
malinkinsa opened this issue Sep 7, 2022 · 2 comments · Fixed by #13873
Closed

Custom default Reader role #13383

malinkinsa opened this issue Sep 7, 2022 · 2 comments · Fixed by #13873

Comments

@malinkinsa
Copy link

malinkinsa commented Sep 7, 2022

At this moment, user with default Reader role can watch input info and other information about clusters.

On input page, for example in kafka custom config, they can found sensitive data

It would be nice to be able to remove the ability to access a number of pages for a role Reader.

Reader permissions scope:

"clusterconfigentry:read",
"indexercluster:read",
"messagecount:read",
"journal:read",
"messages:analyze",
"inputs:read",
"metrics:read",
"fieldnames:read",
"buffers:read",
"system:read",
"jvmstats:read",
"decorators:read",
"throughput:read",
"messages:read"

Your Environment

  • Graylog Version: 4.3.5
  • Elasticsearch Version: 7.10
  • MongoDB Version: 4
@thll
Copy link
Contributor

thll commented Nov 2, 2022

@malinkinsa thanks for the report!

Just to clarify the issue you are reporting: on the inputs page, the configuration for the Kafka input will show sensitive information for the custom_properties field like so:

image

@malinkinsa, did you see any other places where sensitive information could be revealed to a Reader?

Usually, sensitive information on the inputs page is replaced with asterisks (********). For the custom_properties, this has not been implemented. Rather than providing means to customize the Reader role, I think we should change how the custom_properties for the Kafka input are displayed and/or stored.

@thll thll self-assigned this Nov 2, 2022
@malinkinsa
Copy link
Author

@thll ,

Rather than providing means to customize the Reader role, I think we should change how the custom_properties for the Kafka input are displayed and/or stored.

Yep, this a great solution.

did you see any other places where sensitive information could be revealed to a Reader

Once again checked my setup through the user with Reader role and only in kafka config is it possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants