Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of login form. #13780

Merged
merged 18 commits into from Nov 28, 2022
Merged

Improve styling of login form. #13780

merged 18 commits into from Nov 28, 2022

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Oct 25, 2022

Description

Motivation and Context

This PR is modernizing the login dialog of the web interface.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers merged commit 35a4fa7 into master Nov 28, 2022
@dennisoelkers dennisoelkers deleted the feat/new-login-form branch November 28, 2022 14:05
bernd pushed a commit that referenced this pull request Dec 9, 2022
* Migrating components to TS, adding types.

* Cleaning up component a bit.

* Styling login page differently.

* Cleaning up.

* Using brand color for button.

* Moving chrome to `LoginChrome` component, reusing it.

* Improving typing.

* Fix color of hovered sign-in button.

* Use labels instead of placeholders.

* Fixing up test for `LoginBox`.

* Adding license header.

* Fixing up prop improvement.

* Sticking notifications to top of container.

* Fixing width of container.

* Added changelog snippet.

* Smaller styling improvements

* Removing .jpeg to .jpg to avoid dev server restart.

* Fixing linter hint

Co-authored-by: Linus Pahl <linus@graylog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants