Sort streams case-insensitive in API. #14262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/sort-streams-case-insensitive
branch
from
0dd082f
to
86fadf3
Compare
janheise
reviewed
Dec 21, 2022
graylog2-server/src/main/java/org/graylog2/streams/PaginatedStreamService.java
Show resolved
Hide resolved
janheise
approved these changes
Dec 21, 2022
linuspahl
approved these changes
Dec 21, 2022
This was referenced Dec 22, 2022
ousmaneo
pushed a commit
that referenced
this pull request
Jan 11, 2023
* Sort streams case-insensitive in API. * Extracting index set title before lowercasing it. * Adding test case. * Adding changelog snippet. * Fixing up sorting by status, do not project index set title when not needed. * Using correct field for sorting. * Fixing up order of expected elements. * Cleaning up. * Removing unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Prior to this PR, sorting streams by title/description/... sorted them lexicographically, but case-sensitive. This is most probably not what users are expecting.
This change is now adding functionality which is lower-casing the sort field before applying the sort to it.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: