Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-stop loading indicator issue in authentication backends #14283

Merged
merged 3 commits into from Dec 30, 2022
Merged

Fix non-stop loading indicator issue in authentication backends #14283

merged 3 commits into from Dec 30, 2022

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Dec 21, 2022 •
edited by patrickmann

Motivation and Context

Relates to #13023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Dec 21, 2022
@patrickmann patrickmann removed their request for review December 22, 2022 12:00
ousmaneo
ousmaneo approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the loading state issue on the search form

ousmaneo
ousmaneo requested changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested again usage of the useLoadingState and it seems that these changes are breaking the loading state on the button. i think we should update the backendsOverviews page onSearch function to add the resetLoadingCallback function and execute it when the search result is available.

ousmaneo
ousmaneo approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ousmaneo ousmaneo merged commit c0f056c into master Dec 30, 2022
@ousmaneo ousmaneo deleted the fix-issue-13023 branch December 30, 2022 14:11
ousmaneo pushed a commit that referenced this pull request Jan 11, 2023
@gally47 @ousmaneo
Fix non-stop loading indicator issue in authentication backends (#14283)
9752ddd 
* fix non-stop loading indicator issue

* added changelog entry file

* added resetLoadingCallback to BackendsOverview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

Assignees

@gally47 gally47

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gally47 @ousmaneo