Showing widget placeholders allowing inline widget creation. #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
feat/widget-creation-placeholders
branch
2 times, most recently
from
6c6ca8d
to
496f3c6
Compare
linuspahl
reviewed
Jan 4, 2023
| }), [creators, position, view]); | ||
|
|
||
| return ( | ||
| <Modal title={modalTitle} |
There was a problem hiding this comment.
Is there a need for this title? It looks like now we always display a title when hovering over the modal
| }; | ||
|
|
||
| return ( | ||
| <CreateWidgetButton type="button" onClick={onClick}><HugeIcon><WidgetIcon /></HugeIcon>{title}</CreateWidgetButton> |
There was a problem hiding this comment.
It would be nice to display a title for each button like "Create message count widget"
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: space-evenly; | ||
| `; |
There was a problem hiding this comment.
Let's add a gap here to ensure there is always a gap between each widget tile.
There was a problem hiding this comment.
I also like how it looks, if we would center the tiles.
In this example I also used background: transparent and border-radius: 4px; for the tiles.
| const PlaceholderBox = styled.div(({ theme }) => css` | ||
| opacity: 0; | ||
| transition: visibility 0s, opacity 0.2s linear; | ||
|
|
There was a problem hiding this comment.
Let's add cursor: pointer to this element, just to make it even more clear that you can click everywhere and not only on the icon.
dennisoelkers
force-pushed
the
feat/widget-creation-placeholders
branch
2 times, most recently
from
967dd22
to
6cdfb17
Compare
dennisoelkers
force-pushed
the
feat/widget-creation-placeholders
branch
from
56cff62
to
79a00f0
Compare
dennisoelkers
force-pushed
the
feat/widget-creation-placeholders
branch
from
79a00f0
to
bde2f13
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is adding a feature that adds widget placeholders in empty slots on the widget grid, allowing the user to create widgets in these spots. This removes the need for the user to create a widget and then move it to the desired spot.
/jenkins-pr-deps Graylog2/graylog-plugin-enterprise#4510
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: