New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global user session timeout configuration #14343
Conversation
@patrickmann @boosty Is there a reason that this setting is a Server config file settings have the drawback that they need to be in sync on all Graylog nodes and that changing the setting requires a server restart. The global user session timeout is a good candidate for a runtime rather than a server config file setting. |
Makes sense - I'll fix that |
Thank you! 🙏 Please talk with a frontend developer about where users would set the global session timeout. I probably fits somewhere in "System / Users and Teams". |
Frontend is ready for review. in |
@gally47 No input fields are visible in the system config form when there is no existing configuration entry in the |
… cluster_config" This reverts commit a3fe434.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and the feature works ! I made some comments and suggestion about some findings
graylog2-web-interface/src/components/common/ISODurationInput.jsx
Outdated
Show resolved
Hide resolved
graylog2-web-interface/src/components/users/UserCreate/TimeoutFormGroup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend looks good! I added a small comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Resolves #11379
A new parameter
global_session_timeout_interval
is added toserver.conf
.When this is present, you can no longer configure a timeout per user; and it overrides any previously configured user-specific timeout value!
Re-enable individual session timeouts by deleting the global setting from
server.conf
.