Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure users are unique #14649

Merged
merged 8 commits into from Mar 2, 2023
Merged

Ensure users are unique #14649

merged 8 commits into from Mar 2, 2023

Conversation

patrickmann
Copy link
Contributor

@patrickmann patrickmann commented Feb 10, 2023

Resolves #12963

We are not able to recover if a duplicate user has been inadvertently added. It is unclear how this happens; but it results in GL failing to start due to migration errors. In versions prior to 4.3 we didn't notice, because GL would start in spite of failing migrations.

Handle this more robustly:

  • rename all but one of the duplicate users
  • add a unique index to block future creation of duplicate users

@patrickmann patrickmann marked this pull request as ready for review February 13, 2023 09:28
@mpfz0r mpfz0r self-assigned this Mar 1, 2023
@patrickmann patrickmann requested a review from mpfz0r March 2, 2023 11:03
@patrickmann patrickmann merged commit 45b7336 into master Mar 2, 2023
@patrickmann patrickmann deleted the fix/issue-12963 branch March 2, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique index for users.username
2 participants