Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way we display long field names in aggregation grouping configuration. #14789

Merged
merged 3 commits into from Feb 28, 2023

Conversation

linuspahl
Copy link
Contributor

@linuspahl linuspahl commented Feb 27, 2023

Please note, this PR needs a backport for 5.0

Description

Motivation and Context

As described in #14787 we do no display fields with long names well in the aggregation grouping configuration.

Before:
image

After:

image

Fixes #14787

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

@linuspahl linuspahl changed the title Fix the way we display very long field names in aggregation grouping configuration. Fix the way we display long field names in aggregation grouping configuration. Feb 27, 2023
@linuspahl linuspahl force-pushed the bugfix/aggregation-builder-field-select branch from 7b8cb10 to 8fa0866 Compare February 27, 2023 16:44
@dennisoelkers dennisoelkers merged commit ec5c277 into master Feb 28, 2023
@dennisoelkers dennisoelkers deleted the bugfix/aggregation-builder-field-select branch February 28, 2023 07:44
dennisoelkers pushed a commit that referenced this pull request Feb 28, 2023
…guration. (#14789)

* Fix the way we display very long field names in aggregation grouping configuration.

* Adding changelog.

* Extend changelog.
dennisoelkers added a commit that referenced this pull request Feb 28, 2023
…guration. (`5.0`) (#14802)

* Fix the way we display long field names in aggregation grouping configuration. (#14789)

* Fix the way we display very long field names in aggregation grouping configuration.

* Adding changelog.

* Extend changelog.

* Updating changelog snippet.

---------

Co-authored-by: Linus Pahl <linus@graylog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very long field names are breaking layout of grouping field selects
2 participants