Execute a single rule in isolation #14892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmann
force-pushed
the
rulesimulator
branch
2 times, most recently
from
60b6ee3
to
d290bb6
Compare
bernd
reviewed
Mar 21, 2023
...og2-server/src/main/java/org/graylog/plugins/pipelineprocessor/rest/SimulateRuleRequest.java
Outdated
Show resolved
Hide resolved
AntonEbel
requested changes
Mar 28, 2023
...rver/src/main/java/org/graylog/plugins/pipelineprocessor/processors/PipelineInterpreter.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/plugins/pipelineprocessor/rest/RuleResource.java
Outdated
Show resolved
Hide resolved
AntonEbel
requested changes
Mar 29, 2023
graylog2-server/src/main/java/org/graylog/plugins/pipelineprocessor/rest/RuleResource.java
Outdated
Show resolved
Hide resolved
grotlue
approved these changes
Apr 3, 2023
| @@ -46,7 +46,9 @@ class MessageFields extends React.Component { | |||
|
|
|||
| render() { | |||
| const { message } = this.props; | |||
| const formattedFields = message.formatted_fields; | |||
| // eslint-disable-next-line no-unused-vars | |||
| const { _id, ...formatted_fields } = message.fields; | |||
There was a problem hiding this comment.
Why do we need the _id? I think we can use _ and eslint might not complain, but not sure.
There was a problem hiding this comment.
We basically need formatted_fields only, so we needed to add _id to get the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14891
Leverage existing code in PipelineInterpreter to simulate a single rule in isolation, i.e.
We just take in a message string and run the rule on it.
Introduces a new API, which takes in a rule and an input message. It returns the processed message.