Notify when aggregation search throws an exception #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmann
changed the title
mpfz0r
reviewed
Mar 21, 2023
mpfz0r
reviewed
Mar 21, 2023
...g2-server/src/main/java/org/graylog/events/processor/aggregation/PivotAggregationSearch.java
Outdated
Show resolved
Hide resolved
mpfz0r
reviewed
Mar 21, 2023
| @@ -144,9 +149,18 @@ public AggregationResult doSearch() throws EventProcessorException { | |||
| }); | |||
|
|
|||
| // If we have only EmptyParameterErrors, just return an empty Result | |||
| if (! (errors.stream().filter(e -> !(e instanceof EmptyParameterError)).count() > 1)) { | |||
| if (errors.stream().allMatch(e -> e instanceof EmptyParameterError)) { | |||
There was a problem hiding this comment.
we might consider backporting this fix by itself
There was a problem hiding this comment.
I'll check with triage
mpfz0r
reviewed
Mar 22, 2023
| .addType(Notification.Type.SEARCH_ERROR) | ||
| .addSeverity(Notification.Severity.NORMAL) | ||
| .addTimestamp(DateTime.now(DateTimeZone.UTC)) | ||
| .addKey(searchJob.getId()) |
There was a problem hiding this comment.
I think it would be better to use the eventdefintion id here.
Otherwise we might get a new notification for each failed attempt, which might be a lot.
mpfz0r
reviewed
Mar 22, 2023
| .addSeverity(Notification.Severity.NORMAL) | ||
| .addTimestamp(DateTime.now(DateTimeZone.UTC)) | ||
| .addKey(searchJob.getId()) | ||
| .addDetail("title", "Aggregation search failed") |
There was a problem hiding this comment.
We should also add the title/id of the event definition here
mpfz0r
approved these changes
Mar 22, 2023
ousmaneo
pushed a commit
that referenced
this pull request
Mar 29, 2023
* first draft * cleanup * linter fix * fix tests * review feedback * improve notification information
R4103N
pushed a commit
to R4103N/graylog2-server
that referenced
this pull request
Mar 31, 2023
* first draft * cleanup * linter fix * fix tests * review feedback * improve notification information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14746
An event definition with aggregation will fail silently (with just a log message) when encountering an ES/OS error.
We now also generate a notification to alert the admin that events are getting lost.