Fixed NodeService#allActive usages #15139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
force-pushed
the
fix/node-service-all-typed
branch
from
db1a7fb
to
bab8342
Compare
dennisoelkers
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15129.
Description
The allActive method now returns only nodes of the type defined by the type() implementation, which is SERVER and DATANODE specific. Additionally we'll log a warning in isOnlyLeader and isAnyLeaderPresent if there is a mismatch between type returned by the type() method and SERVER type.
There are no changes to the NodeService interface, so no change in the forwarder is needed.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: