Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unable to add custom field when creating event definition #15226

Merged
merged 2 commits into from Apr 14, 2023
Merged

Fix: Unable to add custom field when creating event definition #15226

merged 2 commits into from Apr 14, 2023

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Apr 14, 2023

Motivation and Context

Fixes #15209

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 changed the title Fix Unable to add custom field when creating event definition Fix: Unable to add custom field when creating event definition Apr 14, 2023
@gally47 gally47 self-assigned this Apr 14, 2023
dennisoelkers
dennisoelkers approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@dennisoelkers dennisoelkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem for me! 🙏

@gally47 gally47 merged commit 6076df8 into master Apr 14, 2023
5 checks passed
@gally47 gally47 deleted the fix-issue-15209 branch April 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisoelkers dennisoelkers dennisoelkers approved these changes

@patrickmann patrickmann Awaiting requested review from patrickmann

@ousmaneo ousmaneo Awaiting requested review from ousmaneo

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@gally47 gally47

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add custom field when creating event definition
2 participants
@gally47 @dennisoelkers