create additional role Sidecar Manager, reviewed existing permissions #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: `sidecars:read` gives too many privileges to the system user. It is necessary that the sidecar user cannot read configurations of all sidecars
moesterheld
changed the title
sidecars:read to Sidecar System role
…admin-privileges-should-it
AntonEbel
requested changes
May 11, 2023
.../main/java/org/graylog/plugins/sidecar/migrations/V20230502164900_AddSidecarManagerRole.java
Outdated
Show resolved
Hide resolved
AntonEbel
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Just some minor things and one thing for the Sidecar Reader role. Currently, this user can click on the edit and update buttons, which results in an error page. I think it would improve the UX if someone from the frontend team would hide these buttons for the reader role. I don't know if we should make these changes in this PR or create an issue for that.
changelog/unreleased/pr-15380.toml
Outdated
| @@ -0,0 +1,6 @@ | |||
| type = "a" | |||
| message = "Add Sidecar Manager role to read and manage sidecars." | |||
There was a problem hiding this comment.
Perhaps we should also mention here the role of the Sidecar Reader.
| import javax.inject.Inject; | ||
| import java.time.ZonedDateTime; | ||
|
|
||
| public class V20230502164900_AddSidecarManagerRole extends Migration { |
There was a problem hiding this comment.
Maybe V20230502164900_AddSidecarManagerAndReaderRole?
created #15844 |
moesterheld
deleted the
feature/12044-get-apisidecarsall-requires-admin-privileges-should-it
branch
|
@kroepke @moesterheld @AntonEbel can this be backported to 5.0? There's a HubSpot issue open for another customer with this same issue (HS-1821909158) who's on Graylog 5.0.10. |
AntonEbel
pushed a commit
that referenced
this pull request
Sep 12, 2023
…#15380) * fix: add `sidecars:read` to Sidecar System role * feat: add SIDECARS_READ restriction to `/sidecars/configurations` endpoint * fix: remove `sidecars:read` from Sidecar System role reason: `sidecars:read` gives too many privileges to the system user. It is necessary that the sidecar user cannot read configurations of all sidecars * feat: add Sidecar Manager role * changelog * fix: add license header * fix: add license header * add reader role and add permissions to manager * add collector permissions for manager * change changelog, rename migration --------- Co-authored-by: Anton Ebel <anton.ebel@graylog.com> (cherry picked from commit 346ee6d)
AntonEbel
pushed a commit
that referenced
this pull request
Sep 12, 2023
…#15380) * fix: add `sidecars:read` to Sidecar System role * feat: add SIDECARS_READ restriction to `/sidecars/configurations` endpoint * fix: remove `sidecars:read` from Sidecar System role reason: `sidecars:read` gives too many privileges to the system user. It is necessary that the sidecar user cannot read configurations of all sidecars * feat: add Sidecar Manager role * changelog * fix: add license header * fix: add license header * add reader role and add permissions to manager * add collector permissions for manager * change changelog, rename migration --------- Co-authored-by: Anton Ebel <anton.ebel@graylog.com> (cherry picked from commit 346ee6d)
This was referenced Sep 12, 2023
AntonEbel
added a commit
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Anton Ebel <anton.ebel@graylog.com> Co-authored-by: Matthias Oesterheld <33032967+moesterheld@users.noreply.github.com> fix timestamp of sidecar roles migration (#16477)
AntonEbel
added a commit
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Anton Ebel <anton.ebel@graylog.com> Co-authored-by: Matthias Oesterheld <33032967+moesterheld@users.noreply.github.com> fix timestamp of sidecar roles migration (#16477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewed permissions of Sidecar System user, made
sidecars/configurationsunavailable to the user since it is only used from the UI, not the sidecar.added Sidecar Manager role with permissions to manage and read sidecars
Motivation and Context
closes #12044
Types of changes
Checklist: