Do not extend session when fetching cluster overview. (5.0)
#15508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not extend session when fetching cluster overview. * Adding changelog snippet. (cherry picked from commit e46367a)
dennisoelkers
force-pushed
the
fix/session-expiration-on-nodes-page-5.0
branch
from
0eb3a3f
to
706ade8
Compare
linuspahl
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #15465 to
5.0.Description
Motivation and Context
Prior to this PR, any page that loads the
ClusterOverviewStorewould trigger a permanent session extension. This happens because the store is listening toNodesStore.list, callingcluster()for every update. This function is doing a fetch in turn, which is not disabling session extension.This PR is fixing this by using
fetchPeriodicallyfor the cluster overview call.Fixes Graylog2/graylog-plugin-enterprise#5158.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: