Use grid-based gap detection for placeholder creation. #15545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
approved these changes
May 24, 2023
9 tasks
dennisoelkers
added a commit
that referenced
this pull request
May 24, 2023
* Adding test case for invalid placeholder. * Adding grid-based gap filling algorithm to generate placeholders. * Compare results regardless of order in array. * Avoid `continue`. * Only add placeholders which are wide enough, skip empty rows. * Removing debug printer. * Adding changelog snippet. (cherry picked from commit f79fb78)
linuspahl
pushed a commit
that referenced
this pull request
May 24, 2023
* Use grid-based gap detection for placeholder creation. (#15545) * Adding test case for invalid placeholder. * Adding grid-based gap filling algorithm to generate placeholders. * Compare results regardless of order in array. * Avoid `continue`. * Only add placeholders which are wide enough, skip empty rows. * Removing debug printer. * Adding changelog snippet. (cherry picked from commit f79fb78) * Fixing up changelog snippet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This requires a backport to
5.1.Description
Motivation and Context
This PR is implementing a different approach for detecting gaps in the widget grid in order to create placeholders for inline widget creation.
Instead of detecting leading, trailing and intermediate gaps by comparing widgets to the boundaries of the grid and itself, it fills a m x n grid with markers for existing widgets. After that, it tries to fill rectangles of the biggest possible size in the unfilled spaces. It avoids creating placeholders for rectangles with a width lower than 2, as well as skipping empty rows between widgets.
This is supposed to avoid placement problems that we have seen in #15308 & #15538.
Fixes #15308.
Fixes #15538.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: