Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UPGRADING.md for GreyNoise Data Adapter Changes #15592

Merged
merged 9 commits into from Jun 7, 2023

Conversation

ryan-carroll-graylog
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog commented May 24, 2023

Update UPGRADING.md for GreyNoise Data Adapter Changes in:
Graylog2/graylog-plugin-integrations#1340
https://github.com/Graylog2/graylog-plugin-enterprise-integrations/pull/1059

For issue: https://github.com/Graylog2/graylog-plugin-enterprise/issues/5157

/nocl

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ryan-carroll-graylog ryan-carroll-graylog marked this pull request as ready for review May 24, 2023 15:24
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-carroll-graylog Since this is the first post-5.1 entry for the file, can you please remove the 5.1 items and adjust the title etc. for 5.2? Thanks!

@ryan-carroll-graylog
Copy link
Contributor Author

@ryan-carroll-graylog Since this is the first post-5.1 entry for the file, can you please remove the 5.1 items and adjust the title etc. for 5.2? Thanks!

Sure thing @bernd!

UPGRADING.md Outdated Show resolved Hide resolved
@bernd bernd merged commit 8e6c0f3 into master Jun 7, 2023
3 of 4 checks passed
@bernd bernd deleted the 5157-deprecate-greynoise-data-adapter branch June 7, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants