Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LastOpened and Favorite items to not show up in internal entity lists #15658

Merged
merged 4 commits into from Jun 7, 2023

Conversation

janheise
Copy link
Contributor

@janheise janheise commented May 31, 2023

Description

Favorite and LastOpened were registered as full entities, which led to errors on the "shared items" list for users because they are no real manageable entities and have no routes in the FE to be edited.
Solution is: not register these items as full entities.

Note: needs backport to 5.1

fixes #15574 #15638

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise merged commit aec6444 into master Jun 7, 2023
4 checks passed
@janheise janheise deleted the fix/issue_15638 branch June 7, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View/edit user fails if user has last_opened history
2 participants