Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create search when replaying events/event definitions. #15688

Merged

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jun 5, 2023

Note: This needs to be backported to 5.1.

Description

Motivation and Context

This is a follow-up to #15453, applying the same fix also for the pages replaying events/event definitions. This is preventing a 404 being turned into an exception when replaying events/event definitions.

Fixes #15552.
Fixes #15689.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers merged commit 4031ebb into master Jun 5, 2023
6 checks passed
@dennisoelkers dennisoelkers deleted the fix/create-search-when-replaying-event-definitions branch June 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants