Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field name (or value) suggestion list jumps to first item, even if an item is already selected/highlighted #15718

Closed
coffee-squirrel opened this issue Jun 7, 2023 · 1 comment · Fixed by #15933
Assignees
Labels

Comments

@coffee-squirrel
Copy link

coffee-squirrel commented Jun 7, 2023

Expected Behavior

If a user has "arrowed down" to highlight a field name/value suggestion, and the field name/value suggestion list (or the suggestions up to and including the highlighted field name/value) doesn't change, the highlighted name/value should not reset to the first item in the list.

Alternatively: if the user has highlighted a field name/value suggestion the suggestion list should not be modified/updated.

Current Behavior

Given I have fields source_priority, source_type, and source (among others), if I type so and arrow down to highlight source (skipping source_priority and source_type) I see the highlighted suggestion jump up to the first item in the list (presumably after /api/search/validate completes-- ~80ms). Something similar happens for field value suggestions.

image

I believe this started after we moved from 5.0.x to 5.1.x.

Steps to Reproduce (for bugs)

  1. Have a 5.1.2 environment
  2. Have fields with a common prefix
  3. Open your browser dev tools and watch XHR requests
  4. Start typing that field name prefix, and after the initial suggestions appear arrow down past the first entry and wait
  5. Note that after the /api/search/validate request completes the first suggestions gets highlighted

Context

This makes working with field name/value suggestions annoying, since the UI wipes out the suggestion I arrowed down to.

Your Environment

  • Graylog Version: 5.1.2
  • Java Version: 17.0.7
  • Elasticsearch Version: 7.10.2
  • MongoDB Version: 5.0.14
  • Browser version: Firefox 114, Chrome 114
@dennisoelkers
Copy link
Member

Hey @coffee-squirrel,

thanks for reporting this! We will look into it soon and improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants