Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable percentage/percentile metrics for event definitions. #15863

Merged
merged 23 commits into from Jul 21, 2023

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This PR is enabling missing metrics in event definitions. Previously, only metrics which take a field only as parameter were usable. This change is now enabling other metrics too by:

  • using SeriesSpec in event definitions instead of custom abstraction
  • adding migration which renames function to type field in MongoDB
  • adds frontend support for additional parameters to percentage/percentile

Fixes #10082.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the refactor/use-series-spec-in-event-definitions branch 3 times, most recently from e56e2e0 to a40a442 Compare July 7, 2023 06:29
@dennisoelkers dennisoelkers requested review from todvora, janheise and mpfz0r and removed request for janheise and todvora July 7, 2023 12:46
@dennisoelkers dennisoelkers force-pushed the refactor/use-series-spec-in-event-definitions branch from 73de22e to 3834a99 Compare July 20, 2023 09:50
Copy link
Contributor

@janheise janheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dennisoelkers dennisoelkers merged commit bf91ef9 into master Jul 21, 2023
5 checks passed
@dennisoelkers dennisoelkers deleted the refactor/use-series-spec-in-event-definitions branch July 21, 2023 07:23
@HenryTheSir
Copy link

HenryTheSir commented Jan 16, 2024

Hi @bernd ,
as this change is also a breaking change in the rest api, can we get this documented?

This broke our clusters after our config deployment pushed the definitions in the "old" style (and the api didn't reject them). Its currently possible to deploy non functional event defintiions via api.
-> I must correct myself, the changes got deployd against an server with 5.1 while the master was already on 5.2 and the migration of definitions already run. A server on 5.2 does not accept requests with missing fields

-> Maybe the clustermember should reject changes if it detects, that the leader is already running a newer version?

Field function gets renamed to type

best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create alert based on percentage thresholds
3 participants