Save & reload updated dashboard after changing title. #16441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
approved these changes
Sep 13, 2023
9 tasks
dennisoelkers
added a commit
that referenced
this pull request
Sep 13, 2023
* Save & reload updated dashboard after changing title. * Adding tests. * Adding changelog snippet. * Adding changelog snippet.
linuspahl
pushed a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR needs a backport to
5.1.Description
Motivation and Context
This PR is fixing an issue described in #16440, where changing the title of a dashboard was not properly saved. This is due to the save view action being called with the original dashboard and not the updated one.
Fixes #16440.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: