Remove Edit Event Definition button from events scoped as immutable #16515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingzacko1
requested review from
danotorrey,
simonychuang,
ryan-carroll-graylog and
zeeklop
…-remove-or-edit-notification-in-illuminate-created-event-in-51x
ryan-carroll-graylog
approved these changes
Sep 19, 2023
danotorrey
approved these changes
Sep 19, 2023
…-remove-or-edit-notification-in-illuminate-created-event-in-51x
…ation-in-illuminate-created-event-in-51x
…ation-in-illuminate-created-event-in-51x
zeeklop
reviewed
Sep 27, 2023
| @@ -104,6 +133,14 @@ const ViewEventDefinitionPage = () => { | |||
| notifications={notifications} /> | |||
| </Col> | |||
| </Row> | |||
| {showDialog && ( | |||
There was a problem hiding this comment.
Looks like the dialog is creating some sort of race condition where is trying to update the state of a component that isn't on the DOM. To solve the issue, move this block outside the DocumentTitle block and wrap both components in a fragment.
<>
<DocumentTitle ....>
</DocumentTitle>
{showDialog && (
<ConfirmDialog ....>
</ConfirmDialog>
)}
</>
maxiadlovskii
pushed a commit
that referenced
this pull request
Oct 4, 2023
…16515) * Remove Edit Event Definition button from events scoped as immutable * Add duplicate button on View Event Definition page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit Event Definitionbutton if the event definition is scoped as immutable. The edit option is already hidden from the More Actions menu.Duplicate Event Definitionbutton to the ViewEventDefinition page toolbarMotivation and Context
closes #15916
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: