Make sure default for matching_type is applied for paginated streams endpoint too.
#16522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janheise
approved these changes
Sep 19, 2023
Merged
9 tasks
dennisoelkers
added a commit
that referenced
this pull request
Sep 19, 2023
…s endpoint too. (#16522) * Make sure default for `matching_type` is applied for paginated streams endpoint too. * Adding changelog snippet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This needs a backport to
5.1.Description
Motivation and Context
This PR is fixing an issue which was introduced in #14085. A slightly different code path is introduced for the paginated streams endpoint, which led to streams missing the
matching_typefield to fail deserializing, because the default formatching_typeis not applied and anullvalue is passed instead to the builder method.Fixes #16474.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: