Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uppercase characters for lookup table test lookup #16909

Merged
merged 5 commits into from Oct 13, 2023

Conversation

grotlue
Copy link
Contributor

@grotlue grotlue commented Oct 12, 2023

Fixes: #14373

Description

The test look up for look up tables would manually override uppercase characters to lowercase.
This has be removed in this PR in order to allow looking up keys with uppercase characters.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grotlue grotlue merged commit e2bc176 into master Oct 13, 2023
5 checks passed
@grotlue grotlue deleted the fix/14373/test-lookup-uppercase branch October 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Lookup does not allow uppercase letters - cannot test case sensitive lookups
2 participants