Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataNode: using hostname as node name default #17025

Merged
merged 10 commits into from Oct 24, 2023
Merged

DataNode: using hostname as node name default #17025

merged 10 commits into from Oct 24, 2023

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Oct 20, 2023 •
edited

Description

Use the hostname as the default if no node name was explicitly set in the configuration.

fixes #17005

needs backport to 5.2

/nocl

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise marked this pull request as ready for review October 20, 2023 08:49
@janheise janheise requested a review from todvora October 20, 2023 08:49
@janheise janheise marked this pull request as draft October 20, 2023 11:18
todvora
todvora approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janheise janheise marked this pull request as ready for review October 23, 2023 11:22
@janheise janheise mentioned this pull request Oct 24, 2023
Merged
9 tasks
@janheise janheise merged commit d709ae8 into master Oct 24, 2023
4 checks passed
@janheise janheise deleted the datanode/use-hostname-as-nodename-if-not-set branch October 24, 2023 09:01
janheise added a commit that referenced this pull request Oct 26, 2023
@janheise
added missing changelog for pr #17025
e8aa7c8
janheise added a commit that referenced this pull request Oct 26, 2023
@janheise
added missing changelog for pr #17025
3f10bc2
janheise added a commit that referenced this pull request Nov 2, 2023
@janheise
DataNode: using hostname as node name default - backport to 5.2 (#17056)
e837c2d 
* using the hostname as the default node-name, if none was specified explicitly

* using the hostname as the default node-name, if none was specified explicitly

* using the hostname as the default node-name, if none was specified explicitly

* nodeName is either set explicitly in the conf file or will be the result of the hostname setting otherwise

* small refactoring

* added missing changelog for pr #17025
janheise added a commit that referenced this pull request Nov 3, 2023
@janheise
added missing changelog for pr #17025 (#17079)
c62b666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataNode: node_name should consider hostname configuration
2 participants
@janheise @todvora