Add logic to change perPage in component ListWithOwnState states when new perPage prop arrives #17278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en new perPage prop would arrive
linuspahl
approved these changes
Nov 14, 2023
linuspahl
pushed a commit
that referenced
this pull request
Nov 14, 2023
… new perPage prop arrives (#17278) * Add logic to change perPage in state of ListWithOwnState component when new perPage prop would arrive * Some refactoring * Add changelog * fix changelog * fix changelog * fix changelog
9 tasks
linuspahl
pushed a commit
that referenced
this pull request
Nov 14, 2023
… new perPage prop arrives (#17278) * Add logic to change perPage in state of ListWithOwnState component when new perPage prop would arrive * Some refactoring * Add changelog * fix changelog * fix changelog * fix changelog
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug happens because we update per page value only on the render stage. This PR adds useEffect which changes the inner state of the ListWithOwnState component.
Motivation and Context
fix: #17261
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl