New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap ContentTooLongException into a BatchSizeTooLargeException #17449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic batch size of archiving depends on catching these exceptions and then retrying the scroll query with a smaller batch size. Fixes Graylog2/graylog-plugin-enterprise#3318
mpfz0r
force-pushed
the
fix-dynamic-archiving-batch-size
branch
from
November 23, 2023 15:27
a37f01f
to
749ebd1
Compare
mpfz0r
changed the title
WIP
Wrap ContentTooLongException into an BatchSizeTooLargeException
Nov 23, 2023
mpfz0r
changed the title
Wrap ContentTooLongException into an BatchSizeTooLargeException
Wrap ContentTooLongException into a BatchSizeTooLargeException
Nov 23, 2023
patrickmann
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nice catch. Pretty elusive since it depends on document size.
On a side note: wondering why we don't have a base class for the search client classes. They have a lot of code in common.
mpfz0r
added a commit
that referenced
this pull request
Nov 24, 2023
* Wrap ContentTooLongException into an BatchSizeTooLargeException The dynamic batch size of archiving depends on catching these exceptions and then retrying the scroll query with a smaller batch size. Fixes Graylog2/graylog-plugin-enterprise#3318 * Add changelog (cherry picked from commit 32cf437)
mpfz0r
added a commit
that referenced
this pull request
Nov 24, 2023
* Wrap ContentTooLongException into an BatchSizeTooLargeException The dynamic batch size of archiving depends on catching these exceptions and then retrying the scroll query with a smaller batch size. Fixes Graylog2/graylog-plugin-enterprise#3318 * Add changelog (cherry picked from commit 32cf437)
patrickmann
pushed a commit
that referenced
this pull request
Nov 24, 2023
… (#17459) * Wrap ContentTooLongException into an BatchSizeTooLargeException The dynamic batch size of archiving depends on catching these exceptions and then retrying the scroll query with a smaller batch size. Fixes Graylog2/graylog-plugin-enterprise#3318 * Add changelog (cherry picked from commit 32cf437)
patrickmann
pushed a commit
that referenced
this pull request
Nov 24, 2023
… (#17458) * Wrap ContentTooLongException into an BatchSizeTooLargeException The dynamic batch size of archiving depends on catching these exceptions and then retrying the scroll query with a smaller batch size. Fixes Graylog2/graylog-plugin-enterprise#3318 * Add changelog (cherry picked from commit 32cf437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic batch size of archiving depends on catching these exceptions
and then retrying the scroll query with a smaller batch size.
Fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/3318
Tested with ES/OS containers with
http.max_content_length=10mb
env.ES:
OS:
Ideally that should have an integration test, but that's just so much work :-/