New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify pivot aggregation search in events #17604
Conversation
Fixes most of the exceptions with missing fields.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't handle only missing group-by fields
Thanks @patrickmann for the review, I'll look at this specific case as well. Adding full integration tests now, so it will be easier to verify such behavior. |
I can reproduce the problem with all-unknown fields error in an integration test now, continue on a fix. |
dd34592
to
89ad0d2
Compare
…aggregation-search
…aggregation-search
/nocl
Description
This
tinychange simplifies significantly the request-response structure of the aggregation. This then avoids many possible parsing errors of the aggregations structure.Motivation and Context
Fixes #17314
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: