Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various unused pieces of code removed #17618

Merged
merged 5 commits into from Dec 7, 2023
Merged

Various unused pieces of code removed #17618

merged 5 commits into from Dec 7, 2023

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented Dec 7, 2023 •
edited

Description

Various unused pieces of code removed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

todvora
todvora approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luk-kaminski luk-kaminski merged commit fc584b8 into master Dec 7, 2023
7 of 8 checks passed
@luk-kaminski luk-kaminski deleted the refac/various_unused_code_removed branch December 7, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luk-kaminski @todvora