Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait till datanode becomes available during startup #17758

Merged
merged 6 commits into from Dec 21, 2023

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Dec 20, 2023

Similarly as with elastic/opensearch, graylog server now waits for an available datanode. Number of attempts and their delay is configurable, reusing elasticsearch_version_probe_attempts and elasticsearch_version_probe_delay, which will be most likely renamed in 6.0.

Motivation and Context

Without the waiting logic, users need to start datanode first and then graylog server, otherwise the server immediately crashes with exception.

How Has This Been Tested?

Existing set of unit tests, manually tested starts

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

Only one small comment: Should we add a note to misc/graylog.conf that the two properties are also used for the data node connectivity check?

@janheise janheise merged commit b0ed190 into master Dec 21, 2023
5 checks passed
@janheise janheise deleted the fix/waiting-for-datanode-availability branch December 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants