Add infrastructure for handling targeted scope checks and entity preservation #17828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects to compare
danotorrey
approved these changes
Jan 3, 2024
ryan-carroll-graylog
changed the title
… variable to avoid breaking changes
danotorrey
approved these changes
Jan 11, 2024
ryan-carroll-graylog
deleted the
allow-adding-notifications-to-illuminate-event-definitions
branch
danotorrey
pushed a commit
that referenced
this pull request
Mar 7, 2024
…ervation (#17828) * Add scoped entity mutability check that accepts existing and updated objects to compare * Add full objects to list of uninstalled entities * Fix failing test * Move preserved entity objects from content pack uninstallation to own variable to avoid breaking changes * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Scoped entity mutability checks to allow some changes by comparing new and old entities. Also updates
ContentPackUninstallationobject to contain full objects for later use in preserving entities.Description
ContentPackUninstallationobject to allow preserving some fields during Illuminate upgrades./nocl
Motivation and Context
Allows previously immutable scoped entities to be mutable under certain conditions.
See Issue: https://github.com/Graylog2/se-feature-requests/issues/36
And Enterprise PR: https://github.com/Graylog2/graylog-plugin-enterprise/pull/6365
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: