New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTL for empty results in lookup tables #17994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmann
commented
Jan 23, 2024
graylog2-web-interface/src/components/lookup-tables/caches/CaffeineCacheFieldSet.tsx
Show resolved
Hide resolved
kodjo-anipah
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Tested with csv.
- key does not exist tll empty not configured -> never updates
- key does not exist first ttl empty configured, key added later -> updates
- ignore empty results -> configuring value for ttl empty is deactivated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16466
Description
Adds optional TTL for empty results in lookup table caching. This is not available if ignore null has been checked.
Motivation and Context
If we are caching empty results, then by default they live forever. This is not compatible with data adapters where the value may change over time, specifically DNS. A fixed expiration (expire after write) is not helpful, because that would potentially expire non-null values prematurely. By tuning the TTL for empty results we can avoid requerying the data source excessively, while still becoming aware of changes in values.
How Has This Been Tested?
Simple test scenario:
-- data adapter check interval = 10s
-- cache: empty TTL = 30s and ignore null = false)
Empty TTL overrides the expire after access setting (for null values). Otherwise we would never update a cached null value, that is being requeried very frequently.
Screenshots (if appropriate):
Types of changes
Checklist: