New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent session extension on indexset details page #18091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise is good, however for one call listed in the issue the header is not set.
Testing results
The following requests should sent with the request header: X-Graylog-No-Session-Extension: true
:
✅/api/system/indexer/indices/multiple
✅/api/system/indexer/overview/$INDEX_SET_ID
❌ /api/system/indexer/indices/$INDEX_SET_ID/list
✅/api/system/cluster_config/org.graylog2.indexer.searches.SearchesClusterConfig
Thank you @grotlue for your review,
This API call does not need to be changed in this case, it does not create an issue with session timeout. You can test it by setting the session timeout of your user to 1mn and going to the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ousmaneo Alright, then let's merge this. 👍
Co-authored-by: Laura <grotlue@users.noreply.github.com>
On the IndexSet details page, the session would not expire even when the user sets up a session expiration time. because of the
X-Graylog-No-Session-Extension
not being set by some of the API calls.This PR uses
fetchPeriodically
, which sets theX-Graylog-No-Session-Extension
header.fix #18063
Types of changes
Checklist: