Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable dashboard widget types #1833

Merged
merged 20 commits into from Feb 22, 2016
Merged

Pluggable dashboard widget types #1833

merged 20 commits into from Feb 22, 2016

Conversation

dennisoelkers
Copy link
Member

What this PR does:

  • Separating DashboardWidget and WidgetStrategy classes to serve different concerns:
    • DashboardWidget: persisting the widget configuration
    • WidgetStrategy: defining the strategy to compute a widget’s value.
  • Moving WidgetStrategy interface and all required classes into plugin module
  • Turning existing subclasses of DashboardWidget into WidgetStrategy classes
  • Adding bindings mapping class names/type aliases to WidgetStrategy factories
  • Adding factory to create WidgetStrategy instances based on class name/type alias
  • Separate dashboard/widget REST resources preparing to offer resource which returns available widget types + config information
  • Extract widget value caching into separate WidgetResultCache class, used by REST resources but not tied into persistence/strategy classes.
  • Some cleanup of duplicated TimeRange handling.

What this PR does not do:

  • Supplying endpoint to list available widget types/config schemas
  • Configuration checks for supplied widget configuration
  • UI functionality

@dennisoelkers dennisoelkers added this to the 2.0.0 milestone Feb 18, 2016
@dennisoelkers dennisoelkers force-pushed the feature-pluggable-dashboard-widget-types branch from 6b1709c to 730a713 Compare February 18, 2016 14:41
dennisoelkers and others added 16 commits February 22, 2016 10:54
@dennisoelkers @bernd
Separate wudget persistence and strategies, add strategies to bindings.
6266278
@dennisoelkers @bernd
Unify widget class signatures, look up builtin widgets in binding.
5e556ab
@dennisoelkers @bernd
Adding license headers.
73343a1
@dennisoelkers @bernd
Invalidate widget result cache when widget is updated/removed.
72ae7ca
@dennisoelkers @bernd
Clean up widget instantiation, use TimeRangeFactory wherever possible.
a403309
@dennisoelkers @bernd
Adding license header.
79faa0d
@dennisoelkers @bernd
Fix test initialization.
eedb0ef
@dennisoelkers @bernd
Persist widget-specific config options.
88dc69c
@dennisoelkers @bernd
Extract widget related functionality into DashboardWIdgetsResource.
a48f8be
@dennisoelkers @bernd
Removing icky import.
196d7a0
@dennisoelkers @bernd
Reorder for clarity, improve URI generation a bit.
a2fa7eb
@dennisoelkers @bernd
Unify timerange format in create widget calls.
26f133c 
Before this, the timerange specification of the call was intermingled
with the general widget configuration. This is now being strictly
separated and the web interface generates a proper request object.
@bernd
Restore the "relative" -> "range" field change that was in here before
f5563b4 
Unbreaks adding a widget to a dashboard.
@bernd
Remove duplicate licenses
81d8e24
@bernd
Remove unused type parameter from installWidgetStrategy* methods
c7c746c
@bernd
Fix class imports after rebase
858a8a0
@bernd bernd force-pushed the feature-pluggable-dashboard-widget-types branch from b531731 to 858a8a0 Compare February 22, 2016 09:56
@bernd bernd self-assigned this Feb 22, 2016
bernd added a commit that referenced this pull request Feb 22, 2016
@bernd
Merge pull request #1833 from Graylog2/feature-pluggable-dashboard-wi…
113e0c6 
…dget-types

Pluggable dashboard widget types
@bernd bernd merged commit 113e0c6 into master Feb 22, 2016
@bernd bernd deleted the feature-pluggable-dashboard-widget-types branch February 22, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bernd bernd

Labels
infrastructure ready-for-review
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dennisoelkers @bernd