show Journal Size in In-Place Migration steps #18492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousmaneo
requested changes
Mar 6, 2024
| fetchJournalDowntimeSize, | ||
| { | ||
| onError: (errorThrown) => { | ||
| UserNotification.error(`Loading Data Node failed with status: ${errorThrown}`, |
There was a problem hiding this comment.
Suggested change
| UserNotification.error(`Loading Data Node failed with status: ${errorThrown}`, | |
| UserNotification.error(`Loading Data Node migration journal estimate failed with status: ${errorThrown}`, |
| { | ||
| onError: (errorThrown) => { | ||
| UserNotification.error(`Loading Data Node failed with status: ${errorThrown}`, | ||
| 'Could not load Data Node'); |
There was a problem hiding this comment.
Suggested change
| 'Could not load Data Node'); | |
| 'Could not load Data Node journal size estimate.'); |
| <h3>Journal downtime size warning</h3> | ||
| <p>Please note that during migration data processing will stop on your Graylog node, this will result in the journal growing in size.</p> | ||
| <p>Therefore increase your journal volume size.</p> | ||
| <p>Size: <b>{data} KB/min</b></p> |
There was a problem hiding this comment.
Suggested change
| <p>Size: <b>{data} KB/min</b></p> | |
| <p>Your current journal throughput is: <b>{data} KB/min</b></p> |
| </> | ||
| ); | ||
| const JournalDowntimeWarning = ({ currentStep, onTriggerStep }: MigrationStepComponentProps) => { | ||
| const { data } = useJournalDowntimeSize(); |
There was a problem hiding this comment.
We should also handle displaying a message when there is an error when getting the throughput estimation.
moesterheld
approved these changes
Mar 6, 2024
janheise
pushed a commit
that referenced
this pull request
Mar 7, 2024
* show JournalDowntimeSize * changelog file * fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist: