Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate license warning in DataNodesClusterManagementPage #18559

Merged
merged 5 commits into from Mar 13, 2024
Merged

fix duplicate license warning in DataNodesClusterManagementPage #18559

merged 5 commits into from Mar 13, 2024

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Mar 11, 2024 •
edited

/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/6740

Screenshot 2024-03-11 at 10 30 45

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Mar 11, 2024
@gally47 gally47 requested a review from ousmaneo March 11, 2024 11:43
ousmaneo
ousmaneo approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@gally47 gally47 merged commit 83f93e1 into master Mar 13, 2024
6 checks passed
@gally47 gally47 deleted the fix-duplicate-license-warning branch March 13, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

Assignees

@gally47 gally47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gally47 @ousmaneo