Fix several search export client issues #18787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The export client did not report any errors if only individual shards fail. - The default sort order was wrong. We did sort by "timestamp.ASC, timestamp.DESC, gl2_second_sort_field.DESC" Change this to: "timestamp.ASC, gl2_second_sort_field.ASC" - The ExportBackendIT tests were producing errors because the templates were applied for '*' which included the ism indices and their compound templates. Maybe we can use `graylog_*` for all tests, but for now make the wildcard configurable for each test. - Add proper cleanup between each ExportBackendIT test - Add missing mocking. some tests were running against all indices which is something that never happens in the real world. - Add test for the missing sort field (gl2_second_sort_field) fix - Add test for reporting individual shard failures
mpfz0r
force-pushed
the
fix-export-client-error-handling
branch
from
a2ae859
to
506d059
Compare
...asticsearch7/src/main/java/org/graylog/storage/elasticsearch7/views/export/ExportClient.java
Outdated
Show resolved
Hide resolved
...st/resources/org/graylog/storage/opensearch2/views/export/messages-with-old-field-types.json
Outdated
Show resolved
Hide resolved
.../test/java/org/graylog/storage/elasticsearch7/views/export/ElasticsearchExportBackendIT.java
Show resolved
Hide resolved
luk-kaminski
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export client did not report any errors if only individual shards fail.
The default sort order was wrong.
We did sort by "timestamp.ASC, timestamp.DESC, gl2_second_sort_field.DESC"
Change this to: "timestamp.ASC, gl2_second_sort_field.ASC"
The ExportBackendIT tests were producing errors because the templates
were applied for '*' which included the ism indices and their
compound templates. Maybe we can use
graylog_*for all tests, butfor now make the wildcard configurable for each test.
Add proper cleanup between each ExportBackendIT test
Add missing mocking. some tests were running against all indices
which is something that never happens in the real world.
Add test for the missing sort field (gl2_second_sort_field) fix
Add test for reporting individual shard failures
/nocl