Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Update&close rule in source editor shows warning dialog #19008

Closed
moesterheld opened this issue Apr 11, 2024 · 5 comments · Fixed by #19059
Closed

Create/Update&close rule in source editor shows warning dialog #19008

moesterheld opened this issue Apr 11, 2024 · 5 comments · Fixed by #19059
Assignees
Labels
blocker If not finished by release date, the release will be postponed. bug test-day triaged

Comments

@moesterheld
Copy link
Contributor

Expected Behavior

No warning dialog is shown

Current Behavior

When creating a new rule using the source code editor or clicking "Update and close" the following dialog is shown, which is wrong
image
The rule is saved whatever is clicked, however the editor is only closed when clicking "OK"

Steps to Reproduce (for bugs)

  1. Create a new rule in the source editor, click "Create rule"
  2. Dialog is shown, click ok to go to the rules list
  3. Edit generated rule
  4. Click "Update & Close"
  5. Dialog is shown once again

Your Environment

  • Graylog Version: 6.0.0.rc2
  • Java Version:
  • OpenSearch Version:
  • MongoDB Version:
  • Operating System:
  • Browser version:
@damianharouff
Copy link

This was noted in #18718 and still present in rc.2. Are we going to release with this bug in place?

@patrickmann
Copy link
Contributor

patrickmann commented Apr 11, 2024

My bad - #18718 is marked blocker, so it needs to be backported to 6.0. I was confused because it had been set to status done.
Adding the blocker label here too for good measure. I feel we could improve our process for tracking issues for backport.

@patrickmann patrickmann added the blocker If not finished by release date, the release will be postponed. label Apr 11, 2024
@kmerz kmerz added the triaged label Apr 12, 2024
@kmerz kmerz assigned zeeklop and unassigned zeeklop Apr 12, 2024
@kmerz
Copy link
Member

kmerz commented Apr 12, 2024

The PR #18880 is fixing for Event Definition. This needs another fix!

@ousmaneo ousmaneo self-assigned this Apr 12, 2024
@zeeklop
Copy link
Contributor

zeeklop commented Apr 12, 2024

@kmerz @ousmaneo
I wasn't able to reproduce the error locally running the latest code. Has this been resolved already?

@ousmaneo
Copy link
Contributor

@zeeklop, I'm currently working on this.
You can only reproduce it using a production build to run Graylog locally or on test environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker If not finished by release date, the release will be postponed. bug test-day triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants