Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manage extractor link for local input #19260

Merged
merged 7 commits into from
May 7, 2024
Merged

Fix manage extractor link for local input #19260

merged 7 commits into from
May 7, 2024

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented May 6, 2024

This PR fixes the issue when clicking on the Manage extractors for local input.

fix #19111

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo requested a review from gally47 May 6, 2024 15:21
@ousmaneo ousmaneo self-assigned this May 6, 2024
@ousmaneo ousmaneo added this to the 6.0.1 milestone May 6, 2024
@ousmaneo ousmaneo requested a review from grotlue May 6, 2024 15:26
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it works fine now, code LGTM.
Thanks for fixing it.

@ousmaneo ousmaneo merged commit 8aedfdf into master May 7, 2024
6 checks passed
@ousmaneo ousmaneo deleted the issue-19111 branch May 7, 2024 12:01
ousmaneo added a commit that referenced this pull request May 7, 2024
* fix node id for local_input_extractors

* add changelog

* fix linter

* fix linter
ousmaneo added a commit that referenced this pull request May 7, 2024
* fix node id for local_input_extractors

* add changelog

* fix linter

* fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Manage extractors" button adds extra "/undefined/"
2 participants