Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filter when searching DB for event definitions #19262

Merged
merged 1 commit into from
May 7, 2024
Merged

Use filter when searching DB for event definitions #19262

merged 1 commit into from
May 7, 2024

Conversation

kingzacko1
Copy link
Contributor

Returns to using PaginatedDBService.findPaginatedWithQueryFilterAndSort when searching event definitions. Event definition configs are then repopulated with any associated Search Filters after the filter has been applied.

Description

Motivation and Context

closes #19007

How Has This Been Tested?

local dev testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kingzacko1 kingzacko1 linked an issue May 6, 2024 that may be closed by this pull request
Event definitions pagination does not seems to consider permissions when calculating total amount. #19007
Closed
danotorrey
danotorrey approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and test successfully! I shared out more than 10 event definitions to a reader user, then logged-in as that user. When viewing the Event Definitions list, it was properly paginated with no gaps in pages.

ryan-carroll-graylog
ryan-carroll-graylog approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests successfully!

@kingzacko1 kingzacko1 merged commit e61d173 into master May 7, 2024
5 checks passed
@kingzacko1 kingzacko1 deleted the 19007-event-definitions-pagination-does-not-seems-to-consider-permissions-when-calculating-total-amount branch May 7, 2024 13:47
kingzacko1 added a commit that referenced this pull request May 7, 2024
@kingzacko1
Use filter when searching DB for event definitions (#19262)
0b1e065
@kingzacko1 kingzacko1 mentioned this pull request May 7, 2024
Merged
9 tasks
kingzacko1 added a commit that referenced this pull request May 8, 2024
@kingzacko1
Use filter when searching DB for event definitions (#19262) (#19278)
1a30b68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danotorrey danotorrey danotorrey approved these changes

@ryan-carroll-graylog ryan-carroll-graylog ryan-carroll-graylog approved these changes

@linuspahl linuspahl Awaiting requested review from linuspahl

Assignees
No one assigned
Labels
needs-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event definitions pagination does not seems to consider permissions when calculating total amount.
3 participants
@kingzacko1 @danotorrey @ryan-carroll-graylog