Fix client-side routing in MenuItem component. (6.0)
#19276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix client-side routing in `MenuItem` component. * Adding changelog snippet. * Simplify logic. * Using `Link` component instead of `onClick`-handler. * Cleaning up.
linuspahl
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #19225 to
6.0.Description
Motivation and Context
With the migration of the
MenuItemcomponent to Mantine, we introduced a regression leading to client-side routing (rendering a new page without a full page refresh) not working when anhrefprop is passed to theMenuItemcomponent.This PR is now fixing this by using the
Link-component instead of a na-element when thehrefprop is specified, is a relative URL andtarget/relare not specified.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: