Adding check is path is unset (or "/") for web_listen_uri parameter.
#2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class WebListenUriValidator implements Validator<URI> { | ||
| @Override | ||
| public void validate(String name, URI value) throws ValidationException { | ||
| if (value != null && !value.getPath().equals("/")) { |
There was a problem hiding this comment.
Unfortunately URI#getPath() can return null which would lead to a NullPointerException here. Maybe just invert the second condition ("/".equals(…)).
There was a problem hiding this comment.
👍 - thanks for the hint! :)
|
LGTM. 👍 |
joschi
pushed a commit
that referenced
this pull request
May 10, 2016
joschi
pushed a commit
to Graylog2/documentation
that referenced
this pull request
May 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we cannot handle a path prefix for the web interface assets, because of the way they are bundled. The config parameter allows one, so we need to explicitly check for it and raise an error when it is set to prevent undefined/unexpected behavior.
Fixes #2191.