Normalize URIs #2213
Merged
Normalize URIs #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, the `gl2ServerUrl` configuration option may end in a slash. As we can't predict when that will happen, this commit is normalizing the path of the generated URI, avoiding URIs with duplicated slashes in their path, as one of the issues described in #2200.
|
LGTM. 👍 |
joschi
pushed a commit
that referenced
this pull request
May 11, 2016
In some situations, the `gl2ServerUrl` configuration option may end in a slash. As we can't predict when that will happen, this change is normalizing the path of the generated URI, avoiding URIs with duplicated slashes in their path, as one of the issues described in #2200. (cherry picked from commit 70198f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, the
gl2ServerUrlconfiguration option may end in a slash. As we can't predict when that will happen, this commit is normalizing the path of generated URIs, avoiding URIs with duplicated slashes in their path (you can see an example in #2200).I was able to reproduce the double slash issue in URIs by setting
rest_listen_uriandrest_transport_uritohttp://127.0.0.1:12900/. The most visible place to see them is the export CSV URL. Other URIs are also affected, but they are normalized by one of the network libraries we use.