Prevent session extension in SystemJobsStore #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has to be back-ported to the |
edmundoa
suggested changes
Mar 16, 2017
| @@ -3,6 +3,7 @@ import Reflux from 'reflux'; | |||
| import URLUtils from 'util/URLUtils'; | |||
| import ApiRoutes from 'routing/ApiRoutes'; | |||
| import fetch from 'logic/rest/FetchProvider'; | |||
| import fetchPeriodically from 'logic/rest/FetchProvider'; | |||
There was a problem hiding this comment.
This is not doing what it should. It uses the default export from FetchProvider, which is the fetch function, so there is no difference with the original code, except that the function is locally using another name.
In order to fix the issue we should use a named import here import { fetchPeriodically }... to use the right function.
edmundoa
suggested changes
Mar 17, 2017
| @@ -2,7 +2,7 @@ import Reflux from 'reflux'; | |||
|
|
|||
| import URLUtils from 'util/URLUtils'; | |||
| import ApiRoutes from 'routing/ApiRoutes'; | |||
| import fetch from 'logic/rest/FetchProvider'; | |||
| import {fetch, fetchPeriodically} from 'logic/rest/FetchProvider'; | |||
There was a problem hiding this comment.
In this case this is also not the recommended way of importing both functions (it breaks the import/named eslint rule). We should use this instead:
import fetch, { fetchPeriodically } from 'logic/rest/FetchProvider';
joschi
added a commit
that referenced
this pull request
Mar 17, 2017
* Prevent session extension in SystemJobsStore Fixes #3587 * Use correct import statement https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/import * Something with import… (cherry picked from commit 4ded9e7)
edmundoa
pushed a commit
that referenced
this pull request
Mar 17, 2017
* Prevent session extension in SystemJobsStore Fixes #3587 * Use correct import statement https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/import * Something with import… (cherry picked from commit 4ded9e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3587