Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline functions to modify lookup tables #7189

Merged
merged 8 commits into from Jan 22, 2020

Conversation

mpfz0r
Copy link
Member

@mpfz0r mpfz0r commented Jan 15, 2020

This adds the following pipeline functions:

  • lookup_set_value("table-name", "key", "value")
  • lookup_set_string_list("table-name", "key", ["value1", "value2"])
  • lookup_add_string_list("table-name", "key", ["value1", "value2"])
  • lookup_remove_string_list("table-name", "key", ["remove1", "remove2"])
  • lookup_clear_key("table-name", "key")

Ideally the types should be List<String> but we cannot store
class instances of generic types at runtime.
- lookup_set_value
- lookup_add_string_list
- lookup_remove_string_list
- lookup_set_string_list
@mpfz0r mpfz0r added this to the 3.2.0 milestone Jan 15, 2020
@mpfz0r mpfz0r requested a review from bernd January 15, 2020 16:15
@bernd bernd self-assigned this Jan 15, 2020
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review.

It would be nice if you could write tests for the pipeline functions. 😉

@mpfz0r mpfz0r requested a review from bernd January 17, 2020 17:01
@mpfz0r
Copy link
Member Author

mpfz0r commented Jan 22, 2020

lookup_clear_key changes LGTM 👍

@bernd bernd merged commit afd6d8d into master Jan 22, 2020
@bernd bernd deleted the lookup-set-pipeline-functions branch January 22, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants