Cleaning up unused frontend code from previous search. #7338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
cleaning-up-unused-code
branch
2 times, most recently
from
5716c6f
to
b39ee5b
Compare
This is required now that the `WidgetsStore` which was importing node types through a comment was removed. Instead of importing the types in the `SearchStore` through a comment again, this change is now adding the `node` types explicitly to the TS config files.
dennisoelkers
force-pushed
the
cleaning-up-unused-code
branch
from
a7ac7d7
to
a16c7ba
Compare
kyleknighted
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
looks great to me! everything appears to be working as expected.
@linuspahl since this is a large code delete, could you take a second look and merge when you're happy?
linuspahl
approved these changes
Feb 7, 2020
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cleaning up the frontend and removes now unused code. The removed code belongs mainly to the pre-3.2 search code which has been replaced now. In addition, I analyzed the frontend build, compared the list of included files to the list of existing files and removed components/modules/css files which have become orphaned.
In a single case (the
TrafficGraphcomponent), a code change was required to replace the usage of theLegacyHistogramcomponent with a usage of theGenericPlotcomponent.Giant list of issues the new search fixes:
As this PR is symbolically concluding the renovation of the search functionality (although we are continuously improving the search experience by adding new features, reimplement missing ones and fixing bugs), it is a good milestone to include a list of issues the new search fixes, which are not addressed by a specific single other PR:
Fixes #520.
Fixes #1844.
Fixes #4822.
Fixes #4836.
Fixes #4900.
Fixes #4955.
Fixes #5060.
Fixes #5065.
Fixes #5137.
Fixes #6071.
Fixes #6073.
Fixes #6110.
Fixes #6114.
Fixes #6140.
Fixes #6516.
Fixes #6598.
Fixes #6619.
Fixes #6628.
Fixes #6660.
Fixes #6734.
Fixes #6759.
Fixes #6809.
Types of changes